Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: set concurrently-init-stats false by default #52454

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 9, 2024

What problem does this PR solve?

Issue Number: close #52453

Problem Summary:

What changed and how does it work?

concurrently-init-stats is a new feature, it should be disabled by default when it is published first.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2024
@hawkingrei hawkingrei force-pushed the disable_concurrently_init_stats branch from b608912 to e6822dc Compare April 9, 2024 09:31
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2024
@hawkingrei hawkingrei changed the title Disable concurrently init stats config: set concurrently-init-stats false by default Apr 9, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 9, 2024
@easonn7
Copy link

easonn7 commented Apr 9, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Apr 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2024
@hawkingrei hawkingrei requested a review from winoros April 9, 2024 10:29
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hi-rustin, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 10:03:15.231874322 +0000 UTC m=+956656.759414860: ☑️ agreed by hi-rustin.
  • 2024-04-09 10:31:35.725558375 +0000 UTC m=+958357.253098918: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit ec8e27a into pingcap:release-8.1 Apr 9, 2024
13 checks passed
@hawkingrei hawkingrei deleted the disable_concurrently_init_stats branch April 9, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants